# No Ord instance for NonEmpty

**URL:** <https://forum.canton.network/t/no-ord-instance-for-nonempty/2964>\
**Category:** App Development\
**Tags:** daml, features and bugs\
**Created:** [August 10, 2021, 12:19am UTC](https://forum.canton.network/t/no-ord-instance-for-nonempty/2964 "2021-08-10T00:19:10Z")\
**Posts on this page:** 5\
**Page:** 1

<div class="post-metadata">

**Author:** ![huw](https://yyz2.discourse-cdn.com/flex034/user_avatar/forum.canton.network/huw/32/2343_2.png) [@huw](https://forum.canton.network/u/huw)\
**Post date:** [August 10, 2021, 12:19am UTC](https://forum.canton.network/t/no-ord-instance-for-nonempty/2964/1 "2021-08-10T00:19:10Z")

</div>

Hi there, it seems that `NonEmpty` does not have an `Ord` instance. Any plans to add this? Would be nice to have. I realize now that I can make PRs onto Daml’s public Github repo, happy to make a PR for this one, should be fairly straightforward to add I think.

---

<div class="post-metadata">

**Author:** ![cocreature](https://yyz2.discourse-cdn.com/flex034/user_avatar/forum.canton.network/cocreature/32/36_2.png) [@cocreature](https://forum.canton.network/u/cocreature)\
**Post date:** [August 10, 2021, 7:01am UTC](https://forum.canton.network/t/no-ord-instance-for-nonempty/2964/2 "2021-08-10T07:01:39Z")

</div>

Hi @huw, an `Ord` instance for `NonEmpty` would definitely me reasonable and we’d happily accept a PR!

---

<div class="post-metadata">

**Author:** ![huw](https://yyz2.discourse-cdn.com/flex034/user_avatar/forum.canton.network/huw/32/2343_2.png) [@huw](https://forum.canton.network/u/huw)\
**Post date:** [August 11, 2021, 1:14am UTC](https://forum.canton.network/t/no-ord-instance-for-nonempty/2964/3 "2021-08-11T01:14:26Z")

</div>

Great! I’ll give it a shot

---

<div class="post-metadata">

**Author:** ![huw](https://yyz2.discourse-cdn.com/flex034/user_avatar/forum.canton.network/huw/32/2343_2.png) [@huw](https://forum.canton.network/u/huw)\
**Post date:** [August 13, 2021, 7:56am UTC](https://forum.canton.network/t/no-ord-instance-for-nonempty/2964/4 "2021-08-13T07:56:25Z")

</div>

Hi @cocreature , I have created the code and tests for this change. Seems I get a 403 error trying to push to a branch on your repo. Do I need to request access?

---

<div class="post-metadata">

**Author:** ![cocreature](https://yyz2.discourse-cdn.com/flex034/user_avatar/forum.canton.network/cocreature/32/36_2.png) [@cocreature](https://forum.canton.network/u/cocreature)\
**Post date:** [August 13, 2021, 3:54pm UTC](https://forum.canton.network/t/no-ord-instance-for-nonempty/2964/5 "2021-08-13T15:54:45Z")

</div>

You can create a pull request from a fork. First fork the repository, then push to a branch on your fork and then create a PR from that. See [Creating a pull request from a fork - GitHub Docs](https://docs.github.com/en/github/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/creating-a-pull-request-from-a-fork) for details.
